Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid duplicate adapter entries #259

Merged
merged 2 commits into from
May 20, 2022

Conversation

cs1137195420
Copy link
Contributor

fix: #258

@casbin-bot
Copy link
Member

@ffyuanda @Zxilly @elfisworking please review

Copy link
Member

@abichinger abichinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is missing a colon after 'fix'
Edit: looks like it is sufficient, if the title follows Angular Commit Message Conventions

casbin/persist/adapter.py Outdated Show resolved Hide resolved
Copy link
Member

@abichinger abichinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@hsluoyz hsluoyz merged commit 8d74386 into casbin:master May 20, 2022
github-actions bot pushed a commit that referenced this pull request May 20, 2022
## [1.16.5](v1.16.4...v1.16.5) (2022-05-20)

### Bug Fixes

* avoid duplicate adapter entries ([#259](#259)) ([8d74386](8d74386))
@github-actions
Copy link

🎉 This PR is included in version 1.16.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cs1137195420 cs1137195420 deleted the fix/duplicate-adapter-entries branch June 26, 2022 04:45
hsluoyz added a commit that referenced this pull request Mar 7, 2023
hsluoyz added a commit that referenced this pull request Mar 7, 2023
github-actions bot pushed a commit that referenced this pull request Mar 7, 2023
# [1.18.0](v1.17.6...v1.18.0) (2023-03-07)

### Features

* revert "fix: avoid duplicate adapter entries ([#259](#259))" ([#290](#290)) ([b573041](b573041))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove_grouping_policy: If there are duplicate group rules, remove_grouping_policy will be invalid
4 participants